feat(2fa): scannable QR code for enrollment - #24
Merged
Merged
Conversation
Adds a client-side QR (qrcode lib, rendered in-browser so the TOTP secret
never leaves the device) to both 2FA enrollment surfaces: Settings -> Security
and the at-login challenge step. The manual setup key and the otpauth deep
link remain as fallbacks ("can't scan?" / "on this phone?").
Frontend-only; backend unchanged.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a QR code to 2FA enrollment so a phone authenticator (Google Authenticator, Authy, 1Password) can scan it instead of typing the key. Shown in both enrollment surfaces: Settings → Security and the at-login challenge step.
Generated client-side with the
qrcodelibrary (rendered to a data URL in the browser), so the TOTP secret never leaves the device. The manual setup key and theotpauth://deep link remain as fallbacks ("Can't scan? Enter this key manually" / "On this phone? Open in authenticator app").Frontend-only; no backend change.
Verification
Typecheck, lint, build, and 132 web tests pass.
🤖 Generated with Claude Code